|
Tailslide -> RE: critique & mac error (4/12/2007 2:59:44)
|
Remove the height for the .leftpic and .leftpic2 and the footer will clear the photos.
It's a very nice looking site you've got there Jennifer.
Couple of things that could do with changing.
Firstly - ensure that you're using actual Heading tags for your headings. Don't do this:
<p><b>Heading</b></p>
It's not "semantic", search engines won't pay it much attention (and they LOVE heading tags) and people using screenreaders can sometimes use heading tags to navigate a page. Plus it makes it much easier to style the headings in the stylesheet.
Secondly, you've got loads of non-breaking spaces in there to provide padding on the page (for the brochures for instance). It's considered better to use padding or margins within the stylesheet to do this.
Thirdly, I'd always warn people if you're going to open a new window (brochures and the link). I think that 95% of the time it's not necessary to open a new window - but if you're going to, warn 'em!
Fourthly, you need more "stuff" in your document head - you haven't got any meta tags to speak of. I'd say at least you'd want something like this:
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<meta name="Description" content="How wonderful your site is" />
<meta name="Keywords" content="useful key phrases" />
(UTF-8 is generally recommended these days but you could also use charset=ISO-8859-1
Fifthly (ok I know that's not a word) I'd add in a "focus" and an "active" rule for all your links including your nav links. Focus provides the same effect as hover for people using keyboards not mice and active does the same thing for people using IE as IE is incompetent! I usually just copy the rule for hover so it'd be like this:
a:focus, a:hover, a:active {Whatever}
(the order is important here!).
One other thing I notice for future reference is that you've got way more divs than you need cluttering up the code and making it harder for you to sort out issues like the one above.
What I'd generally do is to put the absolute bare minimum of divs in.
Start off with just the semantic tags necessary (paragraphs, headings, lists etc etc) to differentiate your content. Then add in divs for the "big" areas (such as containers, headers, footers, sidebars) to give the overall layout.
Then you can usually just refer to the "big" div and the item within it (example - #main p {whatever}) rather than having to add loads more divs or classes. When you can't refer to something or when you need to differentiate something then you can add extra classes or if necessary even extra divs.
Overall it's a very nice job Jennifer and I'm just being picky because it is so nice. I find myself being more critical of the better sites on here than the ones that could be described as "beginner" sites.
|
|
|
|
