|
| |
|
|
urlgurl
Posts: 27
Joined: 1/30/2004
From: Canada, eh
Status: offline
 |
critique & mac error - 4/5/2007 9:51:38
Please have a look at http://www.historicmansionincobourg.com
Any recommendations would be greatly appreciated. Also I am having trouble getting the div with the navigation to line up properly, so if anyone wants to critique the css that would be greatly appreciated as well.
Thanks!
Jennifer in Canada
|
|
|
|
jurgen
Posts: 385
Joined: 1/9/2007
From: Castle Rock, Colorado
Status: offline
|
RE: critique & mac error - 4/5/2007 9:59:11
I think your problem is in the frame set and not in CSS.
_____________________________
Wedding Dresses Colorado
| |
|
|
|
urlgurl
Posts: 27
Joined: 1/30/2004
From: Canada, eh
Status: offline
|
RE: critique & mac error - 4/5/2007 10:05:59
Can you please make reference to the code that would affect the frameset. I have not set the site up in frames, nor have I set up columns or row properties other than in divs.
| |
|
|
|
jurgen
Posts: 385
Joined: 1/9/2007
From: Castle Rock, Colorado
Status: offline
|
RE: critique & mac error - 4/5/2007 10:35:56
.hnav {
width: 750px;
height: 15px;
}
Delete the height in your .hnav and let the div expand with whatever you put in there. That should fix your top navigation.
_____________________________
Wedding Dresses Colorado
| |
|
|
|
urlgurl
Posts: 27
Joined: 1/30/2004
From: Canada, eh
Status: offline
|
RE: critique & mac error - 4/5/2007 11:06:04
I am having a blonde day - he he he
Yes, it is forwarded to: http://www.canadianbridalguide.com/mansion
So that may help. Sorry guys.
| |
|
|
|
urlgurl
Posts: 27
Joined: 1/30/2004
From: Canada, eh
Status: offline
|
RE: critique & mac error - 4/11/2007 22:55:46
K, sorry I got distracted. silly facebook. um j/k
Thank you all so much for the tips so far.
Anyway, I removed the heiht in the .hnav and the top nav is fine. as for the text being over the picture on the bottom nav, I was hoping that someone could point out the error, perhaps I haven't cleared something, that would move the entire nav bar below the pictures.
| |
|
|
|
Tailslide
Posts: 5915
Joined: 5/10/2005
From: Out here on the raggedy edge
Status: offline
|
RE: critique & mac error - 4/12/2007 2:59:44
Remove the height for the .leftpic and .leftpic2 and the footer will clear the photos.
It's a very nice looking site you've got there Jennifer.
Couple of things that could do with changing.
Firstly - ensure that you're using actual Heading tags for your headings. Don't do this:
<p><b>Heading</b></p>
It's not "semantic", search engines won't pay it much attention (and they LOVE heading tags) and people using screenreaders can sometimes use heading tags to navigate a page. Plus it makes it much easier to style the headings in the stylesheet.
Secondly, you've got loads of non-breaking spaces in there to provide padding on the page (for the brochures for instance). It's considered better to use padding or margins within the stylesheet to do this.
Thirdly, I'd always warn people if you're going to open a new window (brochures and the link). I think that 95% of the time it's not necessary to open a new window - but if you're going to, warn 'em!
Fourthly, you need more "stuff" in your document head - you haven't got any meta tags to speak of. I'd say at least you'd want something like this:
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<meta name="Description" content="How wonderful your site is" />
<meta name="Keywords" content="useful key phrases" />
(UTF-8 is generally recommended these days but you could also use charset=ISO-8859-1
Fifthly (ok I know that's not a word) I'd add in a "focus" and an "active" rule for all your links including your nav links. Focus provides the same effect as hover for people using keyboards not mice and active does the same thing for people using IE as IE is incompetent! I usually just copy the rule for hover so it'd be like this:
a:focus, a:hover, a:active {Whatever}
(the order is important here!).
One other thing I notice for future reference is that you've got way more divs than you need cluttering up the code and making it harder for you to sort out issues like the one above.
What I'd generally do is to put the absolute bare minimum of divs in.
Start off with just the semantic tags necessary (paragraphs, headings, lists etc etc) to differentiate your content. Then add in divs for the "big" areas (such as containers, headers, footers, sidebars) to give the overall layout.
Then you can usually just refer to the "big" div and the item within it (example - #main p {whatever}) rather than having to add loads more divs or classes. When you can't refer to something or when you need to differentiate something then you can add extra classes or if necessary even extra divs.
Overall it's a very nice job Jennifer and I'm just being picky because it is so nice. I find myself being more critical of the better sites on here than the ones that could be described as "beginner" sites.
_____________________________
"My strategy is so simple an idiot could have devised it"
Little Blue Plane Web Design | Blood, Sweat & Rust - A Land Rover restoration project
| |
|
|
|
Tailslide
Posts: 5915
Joined: 5/10/2005
From: Out here on the raggedy edge
Status: offline
|
RE: critique & mac error - 4/12/2007 3:44:14
I'm a morning person. Can't think straight after about 8pm, usually in bed by 10pm (if not I have to go home).
_____________________________
"My strategy is so simple an idiot could have devised it"
Little Blue Plane Web Design | Blood, Sweat & Rust - A Land Rover restoration project
| |
|
 New Messages |
 No New Messages |
 Hot Topic w/ New Messages |
 Hot Topic w/o New Messages |
 Locked w/ New Messages |
 Locked w/o New Messages |
|
Post New Thread
Reply to Message
Post New Poll
Submit Vote
Delete My Own Post
Delete My Own Thread
Rate Posts
|
|
|
Printable Version 
